Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make previously HQL:ed expressions automatic candidates in SELECT #3638

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Make previously HQL:ed expressions automatic candidates in SELECT #3638

wants to merge 2 commits into from

Conversation

gliljas
Copy link
Member

@gliljas gliljas commented Jan 3, 2025 •
edited
Loading

@gliljas gliljas marked this pull request as draft January 3, 2025 11:06
@fredericDelaporte fredericDelaporte added this to the 5.6 milestone Jan 5, 2025
fredericDelaporte
fredericDelaporte reviewed Jan 5, 2025
View reviewed changes
Copy link
Member

@fredericDelaporte fredericDelaporte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test case?

src/NHibernate/Linq/Visitors/SelectClauseVisitor.cs Show resolved Hide resolved
@gliljas
Copy link
Member Author

gliljas commented Jan 6, 2025

Yes, I'll add some tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericDelaporte fredericDelaporte fredericDelaporte left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
t: Fix
Projects
None yet
Milestone
5.6
Development

Successfully merging this pull request may close these issues.
2 participants
@gliljas @fredericDelaporte